Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update packaging script to Java 14 #2227

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update packaging script to Java 14 #2227

wants to merge 3 commits into from

Conversation

qparis
Copy link
Member

@qparis qparis commented Jun 14, 2020

No description provided.

@plata plata added the packaging Packaging related issues label Jun 14, 2020
@plata
Copy link
Collaborator

plata commented Jun 16, 2020

@qparis if it works, just go for it. I really don't know what's wrong with Codacy currently.

@plata plata mentioned this pull request Jun 16, 2020
Open
@Zemogiter
Copy link
Contributor

I've recompiled the local repo after swaping the .sh file with the one from this PR and I get this error:

bash phoenicis-create-package-java14.sh
Warning: Version not specified. Reading from pom.xml
Using 5.0-SNAPSHOT
/usr/bin/jpackage
WARNING: Using incubator modules: jdk.incubator.jpackage
Error: Invalid Option: [--image]
rmdir: failed to remove 'packages/PhoenicisPlayOnLinux/': no file or directory
mv: can't execute stat on 'packages/Phoenicis PlayOnLinux/': no file or directory
cp: can't execute stat on 'packages/phoenicis': no file or directory
dpkg-deb: building packet "phoenicis-playonlinux" in "Phoenicis_5.0-SNAPSHOT.deb".

@plata
Copy link
Collaborator

plata commented Sep 26, 2020

@qparis what about this PR?

@plata
Copy link
Collaborator

plata commented Sep 26, 2020

With the current version, jlink complains about differing hashes for java.xml.

@qparis
Copy link
Member Author

qparis commented Sep 26, 2020

Is it a blocker?

@plata
Copy link
Collaborator

plata commented Sep 26, 2020

Yes, it aborts.

@qparis
Copy link
Member Author

qparis commented Sep 26, 2020

What is the exact error?

@plata
Copy link
Collaborator

plata commented Sep 26, 2020

https://stackoverflow.com/questions/60904135/error-hash-of-java-xml-differs-to-expected-hash-recorded-in-java-ba

@qparis
Copy link
Member Author

qparis commented Sep 26, 2020

Probably some version conflict

@plata
Copy link
Collaborator

plata commented Sep 26, 2020

Should be https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=944738

@plata
Copy link
Collaborator

plata commented Sep 27, 2020

As described in #2279, using a different JDK version avoids the hash issues with the native Ubuntu OpenJDK.

@plata plata changed the title Jpackage: Java 14 on macOS Update packaging script to Java 14 Sep 27, 2020
@plata
Copy link
Collaborator

plata commented Sep 27, 2020

I had to install binutils but still it doesn't work as expected.

@madoar
Copy link
Collaborator

madoar commented Jan 24, 2021

In my opinion we could use GitHub Actions to automatically create installers for the basic platforms. What do you think?

@plata
Copy link
Collaborator

plata commented Jan 24, 2021

Maybe we should change our CI to actions completely. Let's discuss it in a separate issue.

@madoar
Copy link
Collaborator

madoar commented Jan 24, 2021

Sure. Do you want to open an issue for this?

@plata
Copy link
Collaborator

plata commented Jan 24, 2021

@mador shall we merge this nevertheless?

@madoar
Copy link
Collaborator

madoar commented Jan 24, 2021

If I understand your earlier comments correctly the changed script didn't work for you right?
If it works we should merge it otherwise I think we should let the PR remain open (or close it entirely)

@plata
Copy link
Collaborator

plata commented Jan 24, 2021

Then let's keep it open.

@Zemogiter
Copy link
Contributor

On the latest commit I get this error:

Warning: Version not specified. Reading from pom.xml
Using 5.0-SNAPSHOT
/usr/bin/jpackage
WARNING: Using incubator modules: jdk.incubator.jpackage
jlink failed with: Error: Hash of java.xml (6ccc60ebddab7b301b79ed14fcc5ac14e98bb6612f1039f65c0111ea70140a35) differs to expected hash (9964eca975974fd89a21124fc102300265cecbc3340481f5a4b104bc1c2a256c) recorded in java.base

rmdir: failed to delete 'packages/PhoenicisPlayOnLinux/': No file or directory
mv: unable to execute stat on 'packages/Phoenicis PlayOnLinux/': No file or directory
cp: unable to execute stat on 'packages/phoenicis': No file or directory

java --version output:

openjdk 14.0.2 2020-07-14
OpenJDK Runtime Environment (build 14.0.2+12-Ubuntu-120.04)
OpenJDK 64-Bit Server VM (build 14.0.2+12-Ubuntu-120.04, mixed mode, sharing)

5.4.0-64-generic #72-Ubuntu SMP Fri Jan 15 10:27:54 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

@Zemogiter
Copy link
Contributor

Update: Getting the same error on latest commit.

@plata
Copy link
Collaborator

plata commented Jun 3, 2023

Could you update this to Java 17?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plata plata plata approved these changes

Assignees
No one assigned
Labels
packaging Packaging related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qparis @plata @Zemogiter @madoar